Make configurable Style/MultilineMemoization cop
#4019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pocke
force-pushed
the
enforced-style-multiline-memoization
branch
from
d494213
to
f7e0806
Compare
bbatsov
reviewed
Feb 6, 2017
| @@ -3,11 +3,12 @@ | |||
| module RuboCop | |||
| module Cop | |||
| module Style | |||
| # This cop checks that multiline memoizations are wrapped in a `begin` | |||
| # and `end` block. | |||
| # This cop checks wrapped styles for multiline memoization. | |||
There was a problem hiding this comment.
wrapped styles -> expressions wrapping styles
pocke
force-pushed
the
enforced-style-multiline-memoization
branch
2 times, most recently
from
cce93f3
to
77b24ec
Compare
Currently, `Style/MultilineMemoization` cop is not configurable. This change makes configurable this cop.
pocke
force-pushed
the
enforced-style-multiline-memoization
branch
from
77b24ec
to
812b9d8
Compare
|
Thanks for your review. I've fixed the message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
Style/MultilineMemoizationcop is not configurable.This change makes configurable this cop.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
rake generate_cops_documentation(required only when you've added a new cop or changed the configuration/documentation of an existing cop).