Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #4836] Make Rails/OutputSafety aware of safe navigation operator #4837

Merged
merged 2 commits into from Oct 5, 2017

Conversation

Drenmi
Copy link
Collaborator

@Drenmi Drenmi commented Oct 5, 2017

The cop would not register an offense when #html_safe and #safe_concat were sent using the safe navigation operator. This change fixes that.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Used the same coding conventions as the rest of the project.
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • All tests(rake spec) are passing.
  • The new code doesn't generate RuboCop offenses that are checked by rake internal_investigation.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Updated cop documentation with rake generate_cops_documentation (required only when you've added a new cop or changed the configuration/documentation of an existing cop).

… operator

The cop would not register an offense when `#html_safe` and
`#safe_concat` were sent using the safe navigation operator. This change
fixes that.
@bbatsov bbatsov merged commit 2677293 into rubocop:master Oct 5, 2017
@Drenmi Drenmi deleted the bugfix/output-safety-cop branch October 6, 2017 09:33
@Drenmi
Copy link
Collaborator Author

Drenmi commented Oct 6, 2017

@pocke: Still getting the same intermittent failure since introducing parallel tests on Travis:

NameError:
  uninitialized constant RSpec::Support::Differ
  Did you mean?  RSpec::Support::Differ

Any idea what we can do about this?

@pocke
Copy link
Collaborator

pocke commented Oct 6, 2017

Sorry, I don't have any idea, I can only retry the test...

@Drenmi
Copy link
Collaborator Author

Drenmi commented Oct 6, 2017

Okay, noted. Will investigate if I encounter it again. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants