Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Ruby 1.9 code from Lint/ShadowedException cop #4846

Merged
merged 1 commit into from Oct 8, 2017
Merged

Remove Ruby 1.9 code from Lint/ShadowedException cop #4846

merged 1 commit into from Oct 8, 2017

Conversation

koic
Copy link
Member

@koic koic commented Oct 8, 2017

This looks like code for Ruby 1.9 no longer needed.

Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Used the same coding conventions as the rest of the project.
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • All tests(rake spec) are passing.
  • The new code doesn't generate RuboCop offenses that are checked by rake internal_investigation.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Updated cop documentation with rake generate_cops_documentation (required only when you've added a new cop or changed the configuration/documentation of an existing cop).

@bbatsov bbatsov merged commit 159b895 into rubocop:master Oct 8, 2017
@koic koic deleted the remove_ruby19_code_from_lint_shadowed_exception branch October 8, 2017 17:25
bquorning added a commit to bquorning/rubocop that referenced this pull request Nov 27, 2018
@bquorning
Remove Ruby 1.9 code from Lint/ShadowedException cop
c813d3b 
The "non-inline" `rescue nil` was allowed in Ruby 1.9, but disallowed since 2.0:
rubocop#3249 (comment)

A bit of the code handling `rescue nil` was removed from this cop in
7ef0cf4 (rubocop#4846),
but there was still a bit left behind, plus a few specs.
@bquorning bquorning mentioned this pull request Nov 27, 2018
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@koic @bbatsov