Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add *.gemfile to Bundler cop target #5365

Merged
merged 1 commit into from Dec 31, 2017
Merged

Conversation

sue445
Copy link
Contributor

@sue445 sue445 commented Dec 30, 2017

Creating files with the .gemfile extension is well done.

e.g)

So I thought good that rubocop will check .gemfile.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run rake default or rake parallel. It executes all tests and RuboCop for itself, and generates the documentation.

@bbatsov bbatsov merged commit 7c749d8 into rubocop:master Dec 31, 2017
@sue445 sue445 deleted the gemfile_extension branch December 31, 2017 08:06
pocke added a commit to pocke/rubocop that referenced this pull request Dec 31, 2017
bbatsov pushed a commit that referenced this pull request Dec 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants