Limit SafeNavigation #5606
Merged
Limit SafeNavigation #5606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrosenblum
force-pushed
the
safe_navigation
branch
from
e71d6c1
to
c103cfe
Compare
bbatsov
reviewed
Feb 27, 2018
| @@ -41,6 +41,8 @@ module Style | |||
| # foo&.bar(param1, param2) | |||
| # foo&.bar { |e| e.something } | |||
| # foo&.bar(param) { |e| e.something } | |||
| # foo && foo.bar.baz.qux # method chain with more than 2 methods | |||
There was a problem hiding this comment.
I guess you should mention this in free text in the cop description as well.
rrosenblum
force-pushed
the
safe_navigation
branch
from
c103cfe
to
f733409
Compare
|
@bbatsov one more thought that I had for |
|
Yeah, this makes sense. |
rrosenblum
force-pushed
the
safe_navigation
branch
from
f733409
to
5da84c3
Compare
|
Updated with new highlighting. The |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the changes mentioned in #5595. I will start working on a separate cop to handle consistent usage of safe navigation on all sides of
&&and||.