Move REPL command from rake to bin #5906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related PR rubocop#5905. The main stream of Gem's REPL running seems to be `bin/console` command. `bundle gem` also uses the following template. https://github.com/bundler/bundler/blob/v1.16.2/lib/bundler/templates/newgem/bin/console.tt This PR moves REPL command from `rake repl` task to `bin/console` command then it helps Gem developers to execute REPL intuitively. In order not to confuse RuboCop developers, This PR suddenly did not remove `rake repl` task, but instead display a warning to remove in the future RuboCop 0.58.0. ```console % rake repl DEPRECATION WARNING: `rake repl` is deprecated and will be removed in RuboCop 0.58.0. Please use `bin/console`. [1] pry(RuboCop)> ```
koic
force-pushed
the
move_repl_from_rake_to_bin
branch
from
60c4321
to
56ed514
Compare
|
👍 |
koic
added a commit
to koic/rubocop
that referenced
this pull request
Jun 15, 2018
Currently, A Gem made with `bundle gem <gem-name>` provides `bin/setup` command and `bin/console` command. https://github.com/bundler/bundler/tree/v1.16.2/lib/bundler/templates/newgem/bin `bin/setup` command is for setting up development. RuboCop requires only the `bundle install` setup, so there may be not much merit. However, developers trying to participate in a new development may first think of `bin/setup`. Although I'm not sure the frequency of the aspect to be used, but I opened this PR because `bin/setup` command may be able to help First step. Related PR rubocop#5906.
koic
added a commit
to koic/rubocop
that referenced
this pull request
Jun 15, 2018
Follow up of rubocop#5906. This PR removes `rake repl` task. New features have been added to the master branch after RuboCop 0.57.2. So I guess that the minor version will rise and the next version of RuboCop will be 0.58.0. https://github.com/rubocop-hq/rubocop/blob/38550ff/CHANGELOG.md#master-unreleased This PR will remove `rake repl` according to the following warning. ```console % rake repl DEPRECATION WARNING: `rake repl` is deprecated and will be removed in RuboCop 0.58.0. Please use `bin/console`. [1] pry(RuboCop)> ``` In the future development REPL will be unified into `bin/console`.
bbatsov
pushed a commit
that referenced
this pull request
Jun 15, 2018
Follow up of #5906. This PR removes `rake repl` task. New features have been added to the master branch after RuboCop 0.57.2. So I guess that the minor version will rise and the next version of RuboCop will be 0.58.0. https://github.com/rubocop-hq/rubocop/blob/38550ff/CHANGELOG.md#master-unreleased This PR will remove `rake repl` according to the following warning. ```console % rake repl DEPRECATION WARNING: `rake repl` is deprecated and will be removed in RuboCop 0.58.0. Please use `bin/console`. [1] pry(RuboCop)> ``` In the future development REPL will be unified into `bin/console`.
bbatsov
pushed a commit
that referenced
this pull request
Jun 17, 2018
Currently, A Gem made with `bundle gem <gem-name>` provides `bin/setup` command and `bin/console` command. https://github.com/bundler/bundler/tree/v1.16.2/lib/bundler/templates/newgem/bin `bin/setup` command is for setting up development. RuboCop requires only the `bundle install` setup, so there may be not much merit. However, developers trying to participate in a new development may first think of `bin/setup`. Although I'm not sure the frequency of the aspect to be used, but I opened this PR because `bin/setup` command may be able to help First step. Related PR #5906.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR #5905.
The main stream of Gem's REPL running seems to be
bin/consolecommand.bundle gemalso uses the following template.https://github.com/bundler/bundler/blob/v1.16.2/lib/bundler/templates/newgem/bin/console.tt
This PR moves REPL command from
rake repltask tobin/consolecommand then it helps Gem developers to execute REPL intuitively.In order not to confuse RuboCop developers, This PR suddenly did not remove
rake repltask, but instead display a warning to remove in the future RuboCop 0.58.0.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
rake defaultorrake parallel. It executes all tests and RuboCop for itself, and generates the documentation.