add specs for MemoizedInstanceVariableName

[timoschilling]

Add a regression test for Naming/MemoizedInstanceVariableName with EnforcedStyleForLeadingUnderscores: disallowed, see #6084 (comment) and the following comments.

The manual says that it is ok if method name and variable name are the same, but thats not the case if the both are starting with a _.

With rubocop 0.57.2 this offence didn't happen.

[kenman345]

Are you saying you want to add a definition that this is okay or that you think this is a bug and the spec will help show how we currently are aligned?

[timoschilling]

Both

This adds only a missing test case wich implementation work.

https://github.com/timoschilling/rubocop/blob/4543904220da9550e30d561df38cd7b57ad57c9b/spec/rubocop/cop/naming/memoized_instance_variable_name_spec.rb#L222-L228

This spec shows a regression to 0.57.2, the specs are only green while the spec is pending

https://github.com/timoschilling/rubocop/blob/4543904220da9550e30d561df38cd7b57ad57c9b/spec/rubocop/cop/naming/memoized_instance_variable_name_spec.rb#L106-L113

[timoschilling]

any updates on this?

[bbatsov]

Sorry about the lack of responses. I'm on the road for a couple of weeks and I'm pretty short on time. I'll think more about this when I can.

In the mean time I'd defer to the @rubocop-hq/rubocop-core. :-)

[Ruffeng]

I've been checking the issue and the PR. In my opinion, looks good to me @timoschilling. Do we know any update from @bbatsov about the topic?

[bbatsov]

👍