Add scope methods to Rails/FindEach cop
#6161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
Aug 7, 2018
lib/rubocop/cop/rails/find_each.rb
Outdated
| @@ -15,7 +15,9 @@ module Rails | |||
| class FindEach < Cop | |||
| MSG = 'Use `find_each` instead of `each`.'.freeze | |||
|
|
|||
| SCOPE_METHODS = %i[all where not].freeze | |||
| SCOPE_METHODS = %i[ | |||
| all includes joins left_outer_joins not unscoped where | |||
There was a problem hiding this comment.
If includes, joins and left_outer_joins were added, I thought that we could also add eager_load, left_joins, preload and references.
And this will also change the behavior, so it should be written in the Changes section of CHANGELOG 😃
https://github.com/rubocop-hq/rubocop/blob/63cdaa28a32a7ab475d61666564af468e61078e3/CHANGELOG.md#changes
There was a problem hiding this comment.
Makes sense to me. I'll update the PR. Thanks
repinel
force-pushed
the
improve-rails-find-each
branch
from
424d144
to
217c2de
Compare
Makes the cop also check for the following scopes: `eager_load`, `includes`, `joins`, `left_joins`, `left_outer_joins`, `preload`, `references`, and `unscoped`.
repinel
force-pushed
the
improve-rails-find-each
branch
from
217c2de
to
0f044af
Compare
|
@koic should be good now |
|
Thank you! |
koic
added a commit
to koic/rubocop-rails
that referenced
this pull request
Aug 10, 2018
This PR imports rubocop/rubocop#6161.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the cop check for the following scopes:
includes,joins,left_outer_joins, andunscoped.I can add a changelog entry if this looks good.