Fix Emacs style frozen string literal comment check #6380

y-yagi · 2018-10-12T00:18:42Z

Emacs style + hyphen delimited frozen literal comment(-*- frozen-string-literal: true -*-) is a valid comment.
Ref: https://github.com/ruby/ruby/blob/0cb0835581de93f97861e38acf6ae338ad49f8b5/test/ruby/test_literal.rb#L149-L152

But RuboCop does not recognize this comment currently. This fix allows using that format comment.

Before submitting the PR make sure the following are checked:

Wrote good commit messages.
Commit message starts with [Fix #issue-number] (if the related issue exists).
Feature branch is up-to-date with master (if not - rebase it).
Squashed related commits together.
Added tests.
Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
Run rake default. It executes all tests and RuboCop for itself, and generates the documentation.

koic · 2018-10-12T03:15:44Z

Good catch! I think that it is good to write changelog entry about this change.

Emacs style + hyphen delimited frozen literal comment(`-*- frozen-string-literal: true -*-`) is a valid comment. Ref: https://github.com/ruby/ruby/blob/0cb0835581de93f97861e38acf6ae338ad49f8b5/test/ruby/test_literal.rb#L149-L152 But RuboCop does not recognize this comment currently. This fix allows using that format comment.

y-yagi · 2018-10-12T03:49:12Z

Thanks for your review. I added a changelog entry.

koic · 2018-10-12T06:09:35Z

Thanks!

y-yagi force-pushed the fix_frozen_string_literal_check branch 2 times, most recently from c730b70 to 450c356 Compare October 12, 2018 03:46

y-yagi force-pushed the fix_frozen_string_literal_check branch from 450c356 to 946a26b Compare October 12, 2018 03:48

koic merged commit 8a8d448 into rubocop:master Oct 12, 2018

y-yagi deleted the fix_frozen_string_literal_check branch October 12, 2018 06:29

Provide feedback