Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor refactor of Ctrl-C handling #6537

Merged
merged 4 commits into from
Nov 30, 2018
Merged

Minor refactor of Ctrl-C handling #6537

merged 4 commits into from
Nov 30, 2018

Conversation

deivid-rodriguez
Copy link
Contributor

@deivid-rodriguez deivid-rodriguez commented Nov 30, 2018

This is the same set of changes as #6452, but actually keeping the "2-phase" exit. Basically a minor refactor that moves the full Ctrl-C handling implementation to the runner, so it's easier to follow and understand.

Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@deivid-rodriguez deivid-rodriguez mentioned this pull request Nov 30, 2018
8 tasks
@bbatsov bbatsov merged commit c14ff73 into rubocop:master Nov 30, 2018
@bbatsov
Copy link
Collaborator

bbatsov commented Nov 30, 2018

Thanks!

@deivid-rodriguez deivid-rodriguez deleted the minor_refactor_of_ctrl_c_handling branch November 30, 2018 13:21
@deivid-rodriguez deivid-rodriguez mentioned this pull request Nov 30, 2018
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants