[Fix #6566] Fix a false positive for Layout/EmptyLinesAroundAccessModifier
#6576
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6566.
This PR fixes a false positive for
Layout/EmptyLinesAroundAccessModifier
when at the end of specifying a superclass is missing blank line.The following is originally no offense code.
(It is probably a regression by #6307 💦)
Auto-correct adds a blank line after
private
. This is due to false positives.% cat example.rb class SomeController < SomeOtherController def index; end private + end
This caused the infinite loop in
Layout/EmptyLinesAroundAccessModifier
andLayout/EmptyLinesAroundClassBody
.Auto-correct removes the blank line from after of
private
.% cat example.rb class SomeController < SomeOtherController def index; end private - end
It loops to the first code. This PR fixes the infinite loop.
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).and description in grammatically correct, complete sentences.
bundle exec rake default
. It executes all tests and RuboCop for itself, and generates the documentation.