[Fix #6349] MemoizedInstanceVariableName allows underscored method name #6587
Conversation
…thod name
The following code should be valid:
def _foo
@_foo ||= :foo
end
But before this change it complains that the variable name should be @foo.
The rules need to take into account what the method name is,
and the configured style.
matthewrudy
force-pushed
the
memoized-instance-variable-same
branch
from
8624ded
to
2804f06
Compare
|
Hmm, I thought we have fixed this already. Seems to me that's the 3rd time I see some issue about fixing vars with underscores. 😆 |
|
@bbatsov maybe so. Was still a problem when I did this If it's fixed on master, then fairdos. Appreciate you taking a look. |
|
The changes look good, but your branch has to be rebased on top of the current |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution and understanding! |
|
This issues been automatically closed due to lack of activity. Feel free to re-open it if you ever come back to it. |
We should be allowed to write code like this:
namely if the method name has a leading
_, the memoized variable name should have it too.Currently it gives an error, saying the variable should be named
@foo.This should fix #6349