Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #6603] - Testing RescueEnsureAlignment #6606

Merged
merged 1 commit into from Mar 17, 2019

Conversation

jaredbeck
Copy link
Contributor

Add a test to demonstrate the correct styles of a begin-rescue as the
RHS of an assignment.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Add a test to demonstrate the correct styles of a begin-rescue as the
RHS of an assignment.
@jaredbeck
Copy link
Contributor Author

I think we also need a similar example when the begin is on the same line as the assignment op.

Example added.

@jaredbeck
Copy link
Contributor Author

I think this is ready to merge. The fact that appveyor failed ("Could not find gem 'safe_yaml x86-mingw32'") seems unrelated to my changes.

@bbatsov bbatsov merged commit e1eb1f9 into rubocop:master Mar 17, 2019
@bbatsov
Copy link
Collaborator

bbatsov commented Mar 17, 2019

Thanks!

@jaredbeck jaredbeck deleted the fix_6603 branch March 18, 2019 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants