Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start using expect_correction helper #6695

Merged
merged 1 commit into from
Jan 26, 2019

Conversation

Darhazer
Copy link
Member


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@Darhazer Darhazer force-pushed the rewrite-some-specs-with-expect-correction branch from 16c4c71 to 0fef0d8 Compare January 22, 2019 21:25
@Drenmi
Copy link
Collaborator

Drenmi commented Jan 23, 2019

Great start! 🚀

Still makes me really uneasy that this depends on hidden, shared state, and that it's order-dependent. 😶

Out of curiosity, is there an #expect_no_correction matcher?

@Darhazer Darhazer force-pushed the rewrite-some-specs-with-expect-correction branch from 0fef0d8 to 5f62b7f Compare January 26, 2019 16:26
@Darhazer
Copy link
Member Author

Out of curiosity, is there an #expect_no_correction matcher?

Not yet. I started to rework specs to see how expect_no_correction would fit and if it feels good, create such matcher

@Darhazer Darhazer merged commit 154dfd7 into master Jan 26, 2019
@Darhazer Darhazer deleted the rewrite-some-specs-with-expect-correction branch January 26, 2019 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants