Increase code coverage

[bquorning]

I was looking a bit at our code coverage results, and in these two files I found three unused methods:

• https://codeclimate.com/github/bbatsov/rubocop/lib/rubocop/cop/layout/closing_heredoc_indentation.rb/source
• https://codeclimate.com/github/bbatsov/rubocop/lib/rubocop/cop/style/yoda_condition.rb/source

In ImplicitStringConcatenation I found a couple of lines that could easily be covered by tests, but weren’t:

• https://codeclimate.com/github/bbatsov/rubocop/lib/rubocop/cop/lint/implicit_string_concatenation.rb/source

I am thinking it might be a good idea to have coverage reports in our pull requests. WDYT?

---

Before submitting the PR make sure the following are checked:

• Wrote good commit messages.
• Commit message starts with [Fix #issue-number] (if the related issue exists).
• Feature branch is up-to-date with master (if not - rebase it).
• Squashed related commits together.
• Added tests.
• Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
• The PR relates to only one subject with a clear title
  and description in grammatically correct, complete sentences.
• Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

[Drenmi]

I am thinking it might be a good idea to have coverage reports in our pull requests. WDYT?

I wouldn't mind at all. 🙂