[Fix #6882] Fix an error for Rails/RedundantAllowNil
#6886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rubocop#6882. This PR fixes the following error for `Rails/RedundantAllowNil` when not using both `allow_nil` and `allow_blank`. ```ruby % cat app/models/user.rb class User < ApplicationRecord validates :email, presence: true end ``` ```console % rubocop app/models/user.rb --only Rails/RedundantAllowNil -d For /private/tmp/6882: configuration from /Users/koic/.rbenv/versions/2.6.1/lib/ruby/gems/2.6.0/gems/rubocop-0.67.1/config/default.yml Inspecting 1 file Scanning /private/tmp/6882/app/models/user.rb An error occurred while Rails/RedundantAllowNil cop was inspecting /private/tmp/6882/app/models/user.rb:2:2. undefined method `children' for nil:NilClass /Users/koic/.rbenv/versions/2.6.1/lib/ruby/gems/2.6.0/gems/rubocop-0.67.1/lib/rubocop/cop/rails/redundant_allow_nil.rb:42:in `on_send' (snip) 1 file inspected, no offenses detected 1 error occurred: An error occurred while Rails/RedundantAllowNil cop was inspecting /private/tmp/6882/app/models/user.rb:2:2. Errors are usually caused by RuboCop bugs. Please, report your problems to RuboCop's issue tracker. https://github.com/rubocop-hq/rubocop/issues Mention the following information in the issue report: 0.67.1 (using Parser 2.6.2.0, running on ruby 2.6.1 x86_64-darwin17) ```
koic
commented
Apr 4, 2019
| elsif allow_nil_val.false_type? && allow_blank_val.true_type? | ||
| add_offense(allow_nil, message: MSG_ALLOW_NIL_FALSE) | ||
| end | ||
| offense(allow_nil_val, allow_blank_val, allow_nil) |
There was a problem hiding this comment.
📝 I extracted to the method because it was warned by Metrics cops.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6882.
This PR fixes the following error for
Rails/RedundantAllowNilwhen not using bothallow_nilandallow_blank.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.