Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #6956] Prevent auto-correct confliction of Lint/Lambda and Lint/UnusedBlockArgument #6958

Commits on Apr 23, 2019

  1. [Fix rubocop#6956] Prevent auto-correct confliction of Lint/Lambda

    …and `Lint/UnusedBlockArgument`
    
    Fixes rubocop#6956.
    
    This PR prevents auto-correct confliction of `Lint/Lambda` and `Lint/UnusedBlockArgument`.
    
    The following is the reproduction procedure.
    
    ```ruby
    # example.rb
    c = -> event do
      puts 'Hello world'
    end
    ```
    
    ```console
    % rubocop example.rb -a --only Style/Lambda,Lint/UnusedBlockArgument
    ```
    
    ## Before
    
    A reserved word `lambda` is broken.
    
    ```diff
    % git diff
    diff --git a/example.rb b/example.rb
    index 3445c6f..b8e24f4 100644
    --- a/example.rb
    +++ b/example.rb
    @@ -1,3 +1,3 @@
    -c = -> event do
    +c = lambda_ do |_event|
       puts 'Hello world'
     end
    ```
    
    ## After
    
    It will be a valid code.
    
    ```diff
    % git diff
    diff --git a/example.rb b/example.rb
    index 3445c6f..9c22b37 100644
    --- a/example.rb
    +++ b/example.rb
    @@ -1,3 +1,3 @@
    -c = -> event do
    +c = lambda do |_event|
       puts 'Hello world'
     end
    ```
    koic committed Apr 23, 2019
    Configuration menu
    Copy the full SHA
    6859345 View commit details
    Browse the repository at this point in the history