Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Test with JIT compiler on latest Ruby" #6971

Merged
merged 1 commit into from
Apr 26, 2019
Merged

Conversation

bquorning
Copy link
Contributor

This reverts commit b00329e / PR #6456.

I don't think we have seen any value from running tests with the JIT compiler enabled – so let’s just disable it again.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

This reverts commit b00329e.

I don't think we have seen any value from running tests with the JIT compiler
enabled.
@bquorning bquorning requested review from koic and Drenmi April 26, 2019 07:51
@koic
Copy link
Member

koic commented Apr 26, 2019

I agree.
AFAIK, MJIT may be disabled by default in Ruby 3.0. This is because memory usage increases instead of gaining runtime speed. For example, there is a risk that it won't work with Heroku's smallest dyno.
Of course, I don't know yet what will happen in the future :-)

@koic koic merged commit 6c0ea04 into rubocop:master Apr 26, 2019
@bquorning bquorning deleted the no-jit branch April 26, 2019 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants