[Fix #7023] Added auto-correction for Lint/NumberConversion
#7054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darhazer
reviewed
May 17, 2019
| @@ -108,4 +108,55 @@ | |||
| RUBY | |||
| end | |||
| end | |||
|
|
|||
| context 'autoccorrection' do | |||
There was a problem hiding this comment.
you can add expect_correction() to the existing offending examples
There was a problem hiding this comment.
It's indeed more elegant.
| @@ -1463,6 +1463,7 @@ Lint/NumberConversion: | |||
| Description: 'Checks unsafe usage of number conversion methods.' | |||
| Enabled: false | |||
| VersionAdded: '0.53' | |||
| SafeAutoCorrect: false | |||
There was a problem hiding this comment.
You need to set the VersionChanged on the cop
| lambda do |corrector| | ||
| to_method(node) do |receiver, _to_method| | ||
| corrector.replace(node.loc.expression, | ||
| correct_method(node, receiver)) |
There was a problem hiding this comment.
you can just use node.receiver and skip the to_method matching, but I'm fine with your approach as well
Darhazer
reviewed
May 17, 2019
config/default.yml
Outdated
| @@ -1463,6 +1463,8 @@ Lint/NumberConversion: | |||
| Description: 'Checks unsafe usage of number conversion methods.' | |||
| Enabled: false | |||
| VersionAdded: '0.53' | |||
| VersionChanged: '0.69' | |||
There was a problem hiding this comment.
it would be 0.70 the actual release
Darhazer
approved these changes
May 17, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7023, Added auto-correction for
Lint/NumberConversionBefore submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.