Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix #5628] Rewrite SpaceInsideStringInterpolation #7228

Merged
merged 3 commits into from Jul 24, 2019
Merged

[Fix #5628] Rewrite SpaceInsideStringInterpolation #7228

merged 3 commits into from Jul 24, 2019

Commits on Jul 23, 2019

  1. Recognize tabs as surrounding space 

    Previously tabs and spaces were used to detect offenses but only spaces
were removed. This fixes that mismatch.
    @buehmann
    buehmann committed Jul 23, 2019
    Copy the full SHA
    0db98c3 View commit details
    Browse the repository at this point in the history

  2. Support multi-character tokens in SurroundingSpace 

    `SurroundingSpace` previously assumed that each delimiter token was
exactly 1 char wide. The start of an interpolation `#{` is not.
    @buehmann
    buehmann committed Jul 23, 2019
    Copy the full SHA
    08d1269 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2019

  1. [Fix rubocop#5628] Rewrite SpaceInsideStringInterpolation 

    Rewrite in terms of `SurroundingSpace` and `SpaceCorrector`.
In style `space` there was an overlap in functionality with cop
`ExtraSpace`: This cop no longer removes excess whitespace.
    @buehmann
    buehmann committed Jul 24, 2019
    Copy the full SHA
    87cff0c View commit details
    Browse the repository at this point in the history