Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #7241] Make Style/FrozenStringLiteralComment match only true & false #7251

Merged
merged 1 commit into from Aug 19, 2019

Conversation

tejasbubane
Copy link
Contributor

@tejasbubane tejasbubane commented Aug 2, 2019

Closes #7241

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@bbatsov
Copy link
Collaborator

bbatsov commented Aug 10, 2019

I'm fine with the proposed fix. Probably we should also add some lint cop that checks for bad values in magic comments, but that's a separate topic.

@jonas054
Copy link
Collaborator

@tejasbubane Looks ready to merge, but there's a conflict. Can you fix it?

@tejasbubane
Copy link
Contributor Author

@jonas054 Fixed.

@jonas054 jonas054 merged commit 6c133bb into rubocop:master Aug 19, 2019
@tejasbubane tejasbubane deleted the fix-7241 branch August 20, 2019 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Style/FrozenStringLiteralComment matches arbitrary token as being no offense
4 participants