Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for calls to remote_byebug to Lint/Debugger Cop. #7301

Merged
merged 1 commit into from Aug 22, 2019

Conversation

riley-klingler
Copy link
Contributor

@riley-klingler riley-klingler commented Aug 21, 2019

The byebug gem added a method called remote_byebug for triggering breakpoints in ruby code running remotely. This PR makes the Debugger cop fail if it finds a call to remote_byebug.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists). (N/A)
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

CHANGELOG.md Outdated Show resolved Hide resolved
@koic koic merged commit fc4f8d7 into rubocop:master Aug 22, 2019
@koic
Copy link
Member

koic commented Aug 22, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants