[Fix #7212] Fix a false positive for Layout/EmptyLinesAroundAccessModifier
#7377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
fix_a_false_positive_for_empty_line_around_access_modifier
branch
from
ce9ca6c
to
c889384
Compare
|
Seems the build got stuck. |
…ccessModifier` Fixes rubocop#7212. Fixes rubocop#7246. This PR fixes a false positive for `Layout/EmptyLinesAroundAccessModifier` and `UselessAccessModifier` when using method with the same name as access modifier around a method definition. The main changes are as follows. - Added test for where rubocop#7194 change did not find a regression. - The implementation needed to resolve rubocop#7186 will be moved to `Style/MixinUsage` cop. This solves false positives that occurred in other cops.
koic
force-pushed
the
fix_a_false_positive_for_empty_line_around_access_modifier
branch
from
c889384
to
d568438
Compare
|
Thanks! |
koic
deleted the
fix_a_false_positive_for_empty_line_around_access_modifier
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7212.
Fixes #7246.
This PR fixes a false positive for
Layout/EmptyLinesAroundAccessModifierandUselessAccessModifierwhen using method with the same name as access modifier around a method definition.The main changes are as follows.
Style/MixinUsage#7194 change did not find a regression.Style/MixinUsagecop. This solves false positives that occurred in other cops.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.