Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IfUnlessModifier's co-operation with LineLength in edge cases #7507

Merged
merged 1 commit into from Dec 5, 2019
Merged

Fix IfUnlessModifier's co-operation with LineLength in edge cases #7507

merged 1 commit into from Dec 5, 2019

Commits on Nov 27, 2019

  1. [Fix rubocop#7506] Move LineLength code to mixin and use in IfUnlessM… 

    …odifier

Extract some code that can detect lines that are too long with all the special
cases that are controlled through configuration parameters of the
Metrics/LineLength cop.

The code that is moved to the LineLengthHelp mixin can then be used in
IfUnlessModifier so that it only reports lines on modifier form that are too
long when the LineLength cop would report them.
    @jonas054
    jonas054 committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    bfdda17 View commit details
    Browse the repository at this point in the history