Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #7537] Fix a false positive for Layout/SpaceAroundOperators #7541

Conversation

koic
Copy link
Member

@koic koic commented Nov 30, 2019

Fixes #7537.

This PR fixes a false positive for Layout/SpaceAroundOperators when using a Rational literal with / (e.g. 2/3r).


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@koic koic force-pushed the fix_a_false_positive_for_layout_space_around_operators branch from b659788 to 9a43a47 Compare November 30, 2019 12:59
…ors`

Fixes rubocop#7537.

This PR fixes a false positive for `Layout/SpaceAroundOperators` when
using a Rational literal with `/` (e.g. `2/3r`).
@koic koic force-pushed the fix_a_false_positive_for_layout_space_around_operators branch from 9a43a47 to 16b75b3 Compare December 4, 2019 15:42
@bbatsov bbatsov merged commit ff3910d into rubocop:master Dec 5, 2019
@bbatsov
Copy link
Collaborator

bbatsov commented Dec 5, 2019

Thanks!

@koic koic deleted the fix_a_false_positive_for_layout_space_around_operators branch December 6, 2019 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layout/SpaceAroundOperators should allow literal rationals without spaces
2 participants