Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in CHANGELOG #7840

Merged
merged 1 commit into from Apr 2, 2020
Merged

Fix typo in CHANGELOG #7840

merged 1 commit into from Apr 2, 2020

Conversation

yujideveloper
Copy link
Contributor

@yujideveloper yujideveloper commented Apr 2, 2020

I fix typo of PR link in CHANGELOG


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@yujideveloper yujideveloper changed the title [ci skip] Fix typo in CHANGELOGt [ci skip] Fix typo in CHANGELOG Apr 2, 2020
@koic
Copy link
Member

koic commented Apr 2, 2020

Oops, this is my mistake.

This repository tests the changelog format, please remove [ci skip] from the commit message.
And can you do the same update for v0.81.0.md?
https://github.com/rubocop-hq/rubocop/blob/master/relnotes/v0.81.0.md

@yujideveloper yujideveloper changed the title [ci skip] Fix typo in CHANGELOG Fix typo in CHANGELOG Apr 2, 2020
@yujideveloper
Copy link
Contributor Author

yujideveloper commented Apr 2, 2020

Hi, @koic

Thanks feedback.

I fixed relnotes/v0.81.0.md as same as CHANGELOG.
And I removed [ci skip] from commit message.

@koic koic merged commit 0f572e8 into rubocop:master Apr 2, 2020
@koic
Copy link
Member

koic commented Apr 2, 2020

Thanks for fixing!

@yujideveloper yujideveloper deleted the fix/typo branch April 2, 2020 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants