Allow Generator to take version_added parameter #7897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
Apr 20, 2020
koic
reviewed
Apr 20, 2020
tejasbubane
added a commit
to tejasbubane/rubocop-rspec
that referenced
this pull request
Apr 29, 2020
Default rake task for creating new cop adds rubocop's version to config file, use rubocop-rspec's version instead. Waiting for rubocop/rubocop#7897 to be merged.
Other libraries like `rubocop-rspec` which rely on rubocop's generator will be able to provide in their own version.
tejasbubane
force-pushed
the
generator-version-added
branch
from
db9c08a
to
9459cb6
Compare
|
To clarify: currently, if run from RSpec/Abc:
Description: 'TODO: Write a description of the cop.'
Enabled: pending
VersionAdded: '0.83'While RuboCop RSpec's current version is 1.38.1, and |
|
Not sure why circleci is failing here. |
|
Seems to be a temporary failure, please |
koic
approved these changes
Apr 30, 2020
|
Good to merge? |
|
I'll merge this one. |
tejasbubane
added a commit
to tejasbubane/rubocop-rspec
that referenced
this pull request
May 10, 2020
Default rake task for creating new cop adds rubocop's version to config file, use rubocop-rspec's version instead. Waiting for rubocop/rubocop#7897 to be merged.
mockdeep
pushed a commit
to mockdeep/rubocop-rspec
that referenced
this pull request
Jun 14, 2020
Default rake task for creating new cop adds rubocop's version to config file, use rubocop-rspec's version instead. Waiting for rubocop/rubocop#7897 to be merged.
koic
added a commit
to rubocop/rubocop-rails
that referenced
this pull request
Aug 1, 2020
koic
added a commit
to rubocop/rubocop-performance
that referenced
this pull request
Aug 1, 2020
renawatson68
added a commit
to renawatson68/performance-develop-rubyonrails
that referenced
this pull request
Sep 23, 2022
richardstewart0213
added a commit
to richardstewart0213/performance-build-Performance-optimization-analysis-
that referenced
this pull request
Nov 4, 2022
pirj
pushed a commit
to rubocop/rubocop-capybara
that referenced
this pull request
Dec 29, 2022
Default rake task for creating new cop adds rubocop's version to config file, use rubocop-rspec's version instead. Waiting for rubocop/rubocop#7897 to be merged.
ydah
pushed a commit
to rubocop/rubocop-factory_bot
that referenced
this pull request
Apr 13, 2023
Default rake task for creating new cop adds rubocop's version to config file, use rubocop-rspec's version instead. Waiting for rubocop/rubocop#7897 to be merged.
MarttiCheng
added a commit
to MarttiCheng/Rubocop-Performance
that referenced
this pull request
Sep 28, 2023
SerhiiMisiura
added a commit
to SerhiiMisiura/Rubocop-Performance
that referenced
this pull request
Oct 5, 2023
ydah
pushed a commit
to rubocop/rubocop-rspec_rails
that referenced
this pull request
Mar 27, 2024
Default rake task for creating new cop adds rubocop's version to config file, use rubocop-rspec's version instead. Waiting for rubocop/rubocop#7897 to be merged.
ydah
pushed a commit
to rubocop/rubocop-rspec_rails
that referenced
this pull request
Mar 27, 2024
Default rake task for creating new cop adds rubocop's version to config file, use rubocop-rspec's version instead. Waiting for rubocop/rubocop#7897 to be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other libraries like
rubocop-rspecwhich rely on rubocop's generatorwill be able to provide in their own version to be used in generated config.
example: rubocop/rubocop-rspec#905
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.