Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DidYouMean::SpellChecker may not be available #8143

Conversation

bquorning
Copy link
Contributor

Fixes #7979

In #7979 it was reported that DidYouMean::SpellChecker may not always be available. We can work around that by doing a feature check before using the SpellChecker class.

I did not add any tests.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

In rubocop#7979 it was reported
that DidYouMean::SpellChecker may not always be available. We can work
around it by doing a feature check before using the SpellChecker class.
@bquorning bquorning force-pushed the fix-uninitialized-constant-didyoumean-spellchecker branch from 758fb66 to 752bf8e Compare June 12, 2020 07:49
@bbatsov bbatsov merged commit e013ef1 into rubocop:master Jun 12, 2020
@bbatsov
Copy link
Collaborator

bbatsov commented Jun 12, 2020

Thanks!

@bquorning bquorning deleted the fix-uninitialized-constant-didyoumean-spellchecker branch June 12, 2020 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

uninitialized constant DidYouMean::SpellChecker
3 participants