Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine offense range for Lint/SafeNavigationWithEmpty #8171

Merged

Conversation

koic
Copy link
Member

@koic koic commented Jun 20, 2020

This PR refines offense range for Lint/SafeNavigationWithEmpty.

The following is an example.

return unless foo&.empty?

Before

% bundle exec rubocop example.rb --only Lint/SafeNavigationWithEmpty
(snip)

Offenses:

example.rb:1:1: W: Lint/SafeNavigationWithEmpty: Avoid calling empty?
with the safe navigation operator in conditionals.
return unless foo&.empty?
^^^^^^^^^^^^^^^^^^^^^^^^^

1 file inspected, 1 offense detected

After

% bundle exec rubocop example.rb --only Lint/SafeNavigationWithEmpty
(snip)

Offenses:

example.rb:1:15: W: Lint/SafeNavigationWithEmpty: Avoid calling empty?
with the safe navigation operator in conditionals.
return unless foo&.empty?
              ^^^^^^^^^^^

1 file inspected, 1 offense detected

Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

This PR refines offense range for `Lint/SafeNavigationWithEmpty`.

The following is an example.

```ruby
return unless foo&.empty?
```

## Before

```console
% bundle exec rubocop example.rb --only Lint/SafeNavigationWithEmpty
(snip)

Offenses:

example.rb:1:1: W: Lint/SafeNavigationWithEmpty: Avoid calling empty?
with the safe navigation operator in conditionals.
return unless foo&.empty?
^^^^^^^^^^^^^^^^^^^^^^^^^

1 file inspected, 1 offense detected
```

## After

```console
% bundle exec rubocop example.rb --only Lint/SafeNavigationWithEmpty
(snip)

Offenses:

example.rb:1:15: W: Lint/SafeNavigationWithEmpty: Avoid calling empty?
with the safe navigation operator in conditionals.
return unless foo&.empty?
              ^^^^^^^^^^^

1 file inspected, 1 offense detected
```
@koic koic merged commit a90ec5f into rubocop:master Jun 20, 2020
@koic koic deleted the refine_offense_range_for_safe_navigation_with_empty branch July 13, 2020 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant