[Fix #8424] Fix an error for Lint/IneffectiveAccessModifier
#8427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
fix_error_for_lint_ineffective_access_modifier
branch
from
38336ab
to
a0d9ea8
Compare
bbatsov
reviewed
Jul 31, 2020
| def ineffective_modifier(node, modifier = nil, &block) | ||
| ignored_methods = nil | ||
|
|
||
| def ineffective_modifier(node, ignored_methods = nil, modifier = nil, &block) |
There was a problem hiding this comment.
Unrelated to the fix - we should switch to keyword params here.
There was a problem hiding this comment.
Sure. However, if changed to keyword arguments, it should be prevent new Layout/LineLength or Metrics/MethodLength's offense. This method is limited, so I'd like to keep the changes to a minimum at this time.
bbatsov
approved these changes
Jul 31, 2020
Fixes rubocop#8424. This PR fixes an error for `Lint/IneffectiveAccessModifier` when there is `begin...end` before a method definition.
koic
force-pushed
the
fix_error_for_lint_ineffective_access_modifier
branch
from
a0d9ea8
to
304a464
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8424.
This PR fixes an error for
Lint/IneffectiveAccessModifierwhen there isbegin...endbefore a method definition.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.