Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #8444] Fix an error for `Layout/FirstMethodArgumentLineBreak #8445

Merged

Conversation

koic
Copy link
Member

@koic koic commented Aug 3, 2020

Fixes #8444.

This PR fixes an error for Layout/FirstMethodArgumentLineBreak when using kwargs in super


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@koic koic force-pushed the fix_error_for_first_method_argument_line_break branch from 95f2472 to b53d969 Compare August 3, 2020 11:49
Fixes rubocop#8444.

This PR fixes an error for `Layout/FirstMethodArgumentLineBreak`
when using kwargs in `super`
@koic koic force-pushed the fix_error_for_first_method_argument_line_break branch from b53d969 to 87a4e37 Compare August 3, 2020 13:28
@koic koic merged commit 2da1796 into rubocop:master Aug 3, 2020
@koic koic deleted the fix_error_for_first_method_argument_line_break branch August 3, 2020 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layout/FirstMethodArgumentLineBreak is broken
2 participants