[Fix #8673] Fix the JSON parse error when specifying --format=json and --stdin
#8694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
suppress_stdin_info_for_specifying_format_option
branch
from
2533b56
to
9da0610
Compare
bbatsov
reviewed
Sep 12, 2020
| # Integration tools (like RubyMine) expect to have only the JSON result | ||
| # when specifying JSON format. | ||
| # See: https://github.com/rubocop-hq/rubocop/issues/8673 | ||
| return if @options[:format] == 'json' |
There was a problem hiding this comment.
Btw, shouldn't we do the same for the HTML formatter as well? Might be weird to append plain text to it.
There was a problem hiding this comment.
Sure! I think also JUnit formatter is similar, so I added HTML and JUnit formatters.
…=json` and `--stdin` Fixes rubocop#8673. This PR returns only JSON result when specifying `--format=json` and `--stdin` to fix the JSON parse error. Similar HTML and JUnit formatters are targeted as well.
koic
force-pushed
the
suppress_stdin_info_for_specifying_format_option
branch
from
9da0610
to
225c01e
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8673.
This PR returns only JSON result when specifying
--format=jsonand--stdinto fix the JSON parse error.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.