Address frozen_string_literal no longer applying to interpolated strings
#8743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interpolated and non-interpolated strings will be frozen differently. Splitting their tests will make the change clearer.
As per https://bugs.ruby-lang.org/issues/17104, interpolated string literals will no longer be frozen when frozen string literals are enabled. Therefore, two changes must happen to how we treat interpolated literals - Style/MutableConstant should enforce freezing them - Style/RedundantFreeze should not consider it redundant to freeze them
|
Reading the conversation in the ticket it seems it's not clear if that change will be in Ruby 3.0 (despite the changes that were merged), so let's wait for the final release before changing anything. |
|
I'll close the PR for now in the interest of reducing the number of outstanding PRs. We'll revisit it down the road. |
FWIW, I don't see the intrinsic interest in this. |
|
@bbatsov @marcandre Since that change has indeed made it into Ruby 3, should we consider re-opening this? We are running into the same issue in GitLab, and are now considering to either disable this Cop or patch this in RuboCop itself. https://gitlab.com/gitlab-org/gitlab-styles/-/merge_requests/87 |
7 tasks
splattael
added a commit
to splattael/rubocop
that referenced
this pull request
Aug 23, 2021
Since Ruby 3.0 or higher interpolated strings are not frozen automatically anymore. Therefore, two changes must happen to how we treat interpolated literals * Style/MutableConstant should enforce freezing them * Style/RedundantFreeze should not consider it redundant to freeze them Strongly inspired by rubocop#8743
bbatsov
pushed a commit
that referenced
this pull request
Aug 23, 2021
Since Ruby 3.0 or higher interpolated strings are not frozen automatically anymore. Therefore, two changes must happen to how we treat interpolated literals * Style/MutableConstant should enforce freezing them * Style/RedundantFreeze should not consider it redundant to freeze them Strongly inspired by #8743
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per Ruby Feature #17104, interpolated string literals will no longer be frozen when frozen string literals are enabled.
Therefore, two changes must happen to how we treat interpolated literals
Style/MutableConstantshould enforce freezing themStyle/RedundantFreezeshould not consider it redundant to freeze themThis PR makes those changes.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.Fixes #8703