Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #8771] Fix an error for Style/OneLineConditional #8772

Merged
merged 1 commit into from Sep 23, 2020

Conversation

koic
Copy link
Member

@koic koic commented Sep 23, 2020

Fixes #8771.

This PR fixes an error for Style/OneLineConditional when using if-then-elsif-then-end.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Fixes rubocop#8771.

This PR fixes an error for `Style/OneLineConditional` when using
`if-then-elsif-then-end`.
@bbatsov bbatsov merged commit 5cc162e into rubocop:master Sep 23, 2020
@bbatsov
Copy link
Collaborator

bbatsov commented Sep 23, 2020

Another bug bites the dust! :-)

@koic koic deleted the fix_an_error_for_one_line_conditional branch September 23, 2020 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Style/OneLineConditional crashes on elsif
2 participants