Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #8801] Fix Layouts/SpaceAroundEqualsInParameterDefault #8802

Conversation

rdunlop
Copy link
Contributor

@rdunlop rdunlop commented Sep 27, 2020

This cop is only being handled once per line, due to a
mis-use of the 'opposite_style_detected'/'unrecognized_style_detected'
methods.

Very similar to the issue in #8800


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation. (N/A?)

@rdunlop rdunlop force-pushed the correct_all_occurrences_of_space_around_equals_in_parameter_default branch from 4576ded to 3639ec4 Compare September 27, 2020 13:35
@bbatsov bbatsov changed the title [Fix #8801] [Fix #8801] Fix Layouts/SpaceAroundEqualsInParameterDefault Sep 28, 2020
CHANGELOG.md Outdated Show resolved Hide resolved
This cop is only being handled once per line, due to a
mis-use of the 'opposite_style_detected'/'unrecognized_style_detected'
methods.
@rdunlop rdunlop force-pushed the correct_all_occurrences_of_space_around_equals_in_parameter_default branch from 3639ec4 to 990732c Compare September 30, 2020 04:48
@rdunlop rdunlop requested a review from koic September 30, 2020 04:48
@koic koic merged commit 5423d32 into rubocop:master Sep 30, 2020
@koic
Copy link
Member

koic commented Sep 30, 2020

Thanks!

@rdunlop rdunlop deleted the correct_all_occurrences_of_space_around_equals_in_parameter_default branch September 30, 2020 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants