[Fix #8514] Correct multiple Style/MethodDefParentheses per file. #8817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdunlop
force-pushed
the
correct_all_occurrences_of_method_def_parentheses
branch
from
9b9e321
to
c3f2712
Compare
koic
reviewed
Oct 1, 2020
CHANGELOG.md
Outdated
| @@ -10,6 +10,7 @@ | |||
|
|
|||
| * [#8810](https://github.com/rubocop-hq/rubocop/pull/8810): Fix multiple offense detection for Style/RaiseArgs. ([@pbernays][]) | |||
| * [#8809](https://github.com/rubocop-hq/rubocop/pull/8809): Fix multiple offense detection for Style/For. ([@pbernays][]) | |||
| * [#8514](https://github.com/rubocop-hq/rubocop/pull/8514): Correct multiple `Style/MethodDefParentheses` per file. ([@rdunlop][]) | |||
There was a problem hiding this comment.
Suggested change
| * [#8514](https://github.com/rubocop-hq/rubocop/pull/8514): Correct multiple `Style/MethodDefParentheses` per file. ([@rdunlop][]) | |
| * [#8514](https://github.com/rubocop-hq/rubocop/issues/8514): Correct multiple `Style/MethodDefParentheses` per file. ([@rdunlop][]) |
koic
reviewed
Oct 1, 2020
CHANGELOG.md
Outdated
| @@ -4938,3 +4939,4 @@ | |||
| [@em-gazelle]: https://github.com/em-gazelle | |||
| [@tleish]: https://github.com/tleish | |||
| [@pbernays]: https://github.com/pbernays | |||
| [@rdunlop]: https://github.com/rdunlop | |||
There was a problem hiding this comment.
Can you rebase with the latest master branch and remove it?
Fix the ability to correctly identify and auto-correct multiple MethodDefParentheses violations in a single file.
rdunlop
force-pushed
the
correct_all_occurrences_of_method_def_parentheses
branch
from
c3f2712
to
0570df8
Compare
|
Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the ability to correctly identify and auto-correct multiple
MethodDefParentheses violations in a single file.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation. (N/A?)