Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change SafeYAML from a raise to a warn to prevent breaking other dependencies that require it during the build steps before testing (e.g. Jekyll)
This change was added very recently in this PR: #9004
With the latest update to RuboCop (1.3.0), it raises an exception when
SafeYAML
exists.I use
Jekyll
to build my website which depends onSafeYAML
. In my testing phase I check for both linting errors and other issues with my site build. However, because RuboCop is in these steps, it finds mySafeYAML
executable and fails with the raised exception.My proposal is that we change this from a raised exception to a warning instead.
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.bundle exec rake default
. It executes all tests and RuboCop for itself, and generates the documentation.