Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #9089] Fix an incorrect auto-correct for Style/FormatString #9092

Merged

Conversation

koic
Copy link
Member

@koic koic commented Nov 25, 2020

Fixes #9089

This PR fixes an incorrect auto-correct for Style/FormatString when using springf with second argument that uses an operator.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

…ing`

Fixes rubocop#9089

This PR fixes an incorrect auto-correct for `Style/FormatString`
when using springf with second argument that uses an operator.
@bbatsov bbatsov merged commit 3f7d0c7 into rubocop:master Nov 25, 2020
@bbatsov
Copy link
Collaborator

bbatsov commented Nov 25, 2020

Looks good! Thanks!

@koic koic deleted the fix_an_incorrect_autocorrect_for_format_string branch November 25, 2020 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autocorrect of Style/FormatString changes semantics
2 participants