Fix Layout/FirstArgumentIndentation for operator methods not called as operators.
#9542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvandersluis
force-pushed
the
issue/9538
branch
from
ad0cbbf
to
60239f5
Compare
|
/cc @TSMMark |
dvandersluis
force-pushed
the
issue/9538
branch
2 times, most recently
from
26913df
to
4b43051
Compare
TSMMark
approved these changes
Feb 25, 2021
| @@ -167,6 +167,10 @@ def autocorrect(node) | |||
|
|
|||
| private | |||
|
|
|||
| def bare_operator?(node) | |||
| node.operator_method? && !node.dot? | |||
|
This change looks good. Can you squash the commits into one and add the co-authors to the squashed commit message? |
… as operators. Co-authored-by: TSMMark <mark.allen@vydia.com>
dvandersluis
force-pushed
the
issue/9538
branch
from
4b43051
to
559f74f
Compare
This was referenced Mar 6, 2021
Closed
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #9538.
Operators were explicitly allowed by
Layout/FirstArgumentIndentation, however when an operator method is called as a method (ie. not as a bare operator), the cop should still apply.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.