Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an incorrect auto-correct for Style/EvalWithLocation #9616

Commits on Mar 18, 2021

  1. Fix an incorrect auto-correct for Style/EvalWithLocation

    Fixes standardrb/standard#275.
    
    This PR fixes the following incorrect auto-correct for `Style/EvalWithLocation`
    when using `#instance_eval` with a string argument in parentheses.
    
    ```console
    % cat example.rb
    instance_eval('@foo = foo')
    
    % rubocop -A --only Style/EvalWithLocation
    (snip)
    
    Inspecting 1 file
    C
    
    Offenses:
    
    example.rb:1:1: C: [Corrected] Style/EvalWithLocation: Pass __FILE__ and
    __LINE__ to instance_eval.
    instance_eval('@foo = foo')
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^
    
    1 file inspected, 1 offense detected, 1 offense corrected
    ```
    
    ## Before
    
    ```console
    % cat example.rb
    instance_eval('@foo = foo'), __FILE__, __LINE__
    
    % ruby -c example.rb
    example.rb:1: syntax error, unexpected ',', expecting end-of-input
    instance_eval('@foo = foo'), __FILE__, __LINE__
    ```
    
    ## After
    
    ```console
    % cat example.rb
    instance_eval('@foo = foo', __FILE__, __LINE__)
    
    % ruby -c example.rb
    Syntax OK
    ```
    koic committed Mar 18, 2021
    Copy the full SHA
    10aa0cc View commit details
    Browse the repository at this point in the history