Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an error for Style/SingleLineMethods #9705

Merged
merged 1 commit into from
Apr 17, 2021

Conversation

koic
Copy link
Member

@koic koic commented Apr 17, 2021

This PR fixes the following error for Style/SingleLineMethods.

% cat  example.rb
def some_method; 42 end

% bundle exec rubocop --only Style/SingleLineMethods -d

(snip)

undefined method `arguments' for s(:int, 42):RuboCop::AST::IntNode
Did you mean?  argument?
/Users/koic/src/github.com/rubocop/rubocop/lib/rubocop/cop/style/single_line_methods.rb:118:in `method_body_source'

This is a regression of #9704.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

This PR fixes the following error for `Style/SingleLineMethods`.

```console
% cat  example.rb
def some_method; 42 end

% bundle exec rubocop --only Style/SingleLineMethods -d

(snip)

undefined method `arguments' for s(:int, 42):RuboCop::AST::IntNode
Did you mean?  argument?
/Users/koic/src/github.com/rubocop/rubocop/lib/rubocop/cop/style/single_line_methods.rb:118:in `method_body_source'
```

This is a regression of rubocop#9704.
@koic koic merged commit 7d12a8d into rubocop:master Apr 17, 2021
@koic koic deleted the fix_an_error_for_style_single_line_method branch April 17, 2021 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant