Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #9689] Treat parens around array items the same for children and deeper descendants #9709

Merged
merged 1 commit into from Apr 19, 2021

Conversation

dvandersluis
Copy link
Member

@dvandersluis dvandersluis commented Apr 18, 2021

Previously there was a disparity between these two code blocks:

[
 (
   1
 ),
 2
]
[
 x = (
   1
 ),
 y = 2
]

The first was accepted as "plausible" but the second registered an offense (and was autocorrected to a syntax error because the comma in an array cannot be on its own line).

This change allows both to be treated the same by looking for any ancestor to be an array or hash rather than just the direct parent.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@dvandersluis dvandersluis linked an issue Apr 18, 2021 that may be closed by this pull request
@bbatsov bbatsov merged commit c53803b into rubocop:master Apr 19, 2021
@bbatsov
Copy link
Collaborator

bbatsov commented Apr 19, 2021

Looks good! Thanks!

@dvandersluis dvandersluis deleted the issue/9689 branch September 14, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsafe auto-correct for Style/RedundantParentheses
2 participants