Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #9843] Fix Style/RedundantSelf to allow conditional nodes to use self in the condition when a variable named is shadowed inside #9847

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

dvandersluis
Copy link
Member

Previously, Style/RedundantSelf registered false positives when a condition used self to avoid shadowing a local variable:

a = self.a if self.a

This was because the condition was not correlated to the lvar assign because they happen at different times. This is now fixed so if, unless, while and until nodes are covered.

Fixes #9843.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

…es to use `self` in the condition when a variable named is shadowed inside.
@dvandersluis dvandersluis requested a review from koic June 2, 2021 03:37
@dvandersluis
Copy link
Member Author

Failing CI seems like a false negative.

@koic
Copy link
Member

koic commented Jun 2, 2021

This looks good! Thank you for catching up with while, until, and masgn cases!

@koic koic merged commit 27cb14d into rubocop:master Jun 2, 2021
@dvandersluis dvandersluis deleted the issue/9843 branch September 14, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrong detection of Style/RedundantSelf
2 participants