Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #5022] Fix false negative for Lint/DuplicateMethods inside class << self #9994

Merged
merged 1 commit into from Aug 11, 2021

Conversation

dvandersluis
Copy link
Member

@dvandersluis dvandersluis commented Aug 10, 2021

Requires rubocop/rubocop-ast#197 in order to fix Node#parent_module_name.

Properly handles the updated format of parent_module_name and adds tests to ensure the case from #5022 works.

Also reverts the pending tests in #9995.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@dvandersluis dvandersluis merged commit 8588024 into rubocop:master Aug 11, 2021
@dvandersluis dvandersluis deleted the issue/5022 branch August 11, 2021 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants