Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cosmetic changes #930

Merged
merged 1 commit into from
Nov 5, 2023
Merged

Add cosmetic changes #930

merged 1 commit into from
Nov 5, 2023

Conversation

ydakuka
Copy link
Contributor

@ydakuka ydakuka commented Nov 4, 2023

No description provided.

@@ -214,7 +214,7 @@ Use Unix-style line endings.footnote:[*BSD/Solaris/Linux/macOS users are covered
====
If you're using Git you might want to add the following configuration setting to protect your project from Windows line endings creeping in:

[source,bash]
[source,shell]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is worth noticing in the link:

[for console, ] the syntax highlighter will parse the prompt (e.g., $) at the start of each line, then handle the remaining text using the shell language

Should we use console here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, console looks better here.

README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
@ydakuka ydakuka requested a review from koic November 5, 2023 09:12
@bbatsov bbatsov merged commit 78b6fca into rubocop:master Nov 5, 2023
3 checks passed
@bbatsov
Copy link
Collaborator

bbatsov commented Nov 5, 2023

Thanks!

@ydakuka ydakuka deleted the cosmetic-changes branch November 5, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants