Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only re-dex class files if class files have changed #31

Closed
headius opened this issue Mar 9, 2011 · 7 comments
Closed

Only re-dex class files if class files have changed #31

headius opened this issue Mar 9, 2011 · 7 comments
Labels
Milestone

Comments

@headius
Copy link
Member

headius commented Mar 9, 2011

Currently every time you build "debug" or "release" apk from a ruboto-core project, it re-dexes all of JRuby and your app's Java code. That's obviously unnecessary if the app's logic is mostly in Ruby.

update_scripts helps a lot, of course, but it would be nice if you could just build .apk files without re-dexing stuff that hasn't changed. It would also avoid the confusing situation where an app has been re-built and re-installed, but the scripts have not been updated.

We should have dexing happen as a separate step, dependent on whether the libs jars and the app's .java/.class files have actually changed. If they have not, the existing dex file can be used. This would greatly speed up the build/deploy/test cycle for Ruboto apps.

@jberkel
Copy link
Member

jberkel commented Mar 9, 2011

@headius
Copy link
Member Author

headius commented Mar 9, 2011

Yeah, I've been meaning to try that. Basically we'd have a Ruboto Core app people install, and then other Ruboto apps could just depend in it having the pre-dexed JRuby stuff in /data/data/org.ruboto/files/jruby.jar. Might not be hard to prototype
that.

As a result, Ruboto apps would be tiny.

@donv
Copy link
Member

donv commented Jun 25, 2011

@donv
Copy link
Member

donv commented Aug 20, 2011

I have been able to load a class from a separate app. I have added the code (commented) to RubotoActivity.java.

I have no idea what the next step should be. Please help!

I do create a classloader. How do we make that classloader active for JRuby?

@donv
Copy link
Member

donv commented Aug 26, 2011

The original intent of this issue requires not using ANT to build the APK. I am thinking this might be a good idea, but I would like to hear from you all if you think we should struggle to gain control over the build process, and ditch ANT over time, or strive to re-use as much as possible from the ANT build scripts?

Any thoughts?

@donv
Copy link
Member

donv commented Sep 3, 2011

Postponing to version 0.5.

@donv
Copy link
Member

donv commented Dec 12, 2011

Not re-dexing unchanged classes is now a standard feature of the Android SDK. Closing.

@donv donv closed this as completed Dec 12, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants