Windows cert file paths being treated like inline certs

[jsmartt]

I'm running v2.6.4 of the gem, and the code here determines if each cert is a path or inline certificate by checking if the string starts with a /. This is fine for Linux, but on my Windows box with Ruby 2.3.1 (provided in the Chef DK), that list of certs is:

[
  "C:/opscode/chefdk/embedded/ssl/certs/cacert.pem",
  "C:/opscode/chefdk/embedded/ssl/certs/ca-certificates.crt",
  "C:/opscode/chefdk/embedded/ssl/certs/ca-bundle.crt",
  "C:/opscode/chefdk/embedded/ssl/certs/ca-bundle.pem"
]

This causes these paths to be appended to the cert_inlines array, and eventually causes a OpenSSL::X509::CertificateError (not enough data) when it's added here.

I propose that the regex be updated from /^\// to /^([a-z]:?)?\//i to allow these Windows-style paths. I'd be glad to submit a PR to fix this, but wanted to run it by you guys first.
Thanks!

[michaelklishin]

@jsmartt sounds reasonable. I'd introduce a class predicate method on Bunny::Transport and expose it for tests. Thank you!

[jsmartt]

Great! Thanks @michaelklishin !

[michaelklishin]

@jsmartt do you need a preview release shortly or can you use the tip of 2.6.x-stable for some time?

[jsmartt]

Well this fixes an issue for a new feature, so that new feature will just be broken for Windows users until a new release is available on rubygems. So it's not urgent, but I'm not opposed to a release as soon as possible. 😉 I'm not pulling pre-releases though, so whenever you can get a 2.6.5 version out, I'll be able to use it.

[michaelklishin]

@jsmartt 2.6.5 is out.