Readds auto-rotate option #37
Conversation
| log "Adding rotation #{@meta[:rotate]}" | ||
| case @meta[:rotate] | ||
| when 90 | ||
| @convert_options[:output][:vf] = "'transpose=1'" |
There was a problem hiding this comment.
Were you able to test vf parameter for both libav and ffmpeg?
There was a problem hiding this comment.
No! I don't think I have the proper setup but let me give it a try.
There was a problem hiding this comment.
You don't have to. If the parameters are different, I guess it's better to move this filter to av gem instead of handling it in paperclip-av-transcoder.
There was a problem hiding this comment.
av gem supports rotation using filter_rotate. And the interface is the same for avconv and ffmpeg. So maybe we should keep this auto_rotate option in this gem but call filter_rotate instead.
In the meantime I tested this and it's not working properly because arguments are not being passed correctly. I'm opening another PR in av gem to fix this: ruby-av/av#15
|
Hey @owahab, any news on this? We've been using this in production for a couple of months now and it's working perfectly. |
|
Thank you. |
Thumbnails are being generated with the wrong orientation even when using the auto_rotate option.
Digging through the source, I found out that auto_rotation option is not doing anything.
I also found out that the paperclip-ffmpeg gem did support this before: owahab/paperclip-ffmpeg@3e36704
So I basically applied the same to the paperclip-av-transcoder gem.
I'm not sure why this was removed but it seems to be working fine...