-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis deploy setup #42
Conversation
877f8a7
to
a94f9d0
Compare
chmod 600 /tmp/deploy_rsa; | ||
ssh-add /tmp/deploy_rsa; | ||
|
||
ssh -o StrictHostKeyChecking=no root@$RUNNER_HOST "tsp git -C ./ruby-bench-docker pull --rebase origin master && tsp ./ruby-bench-docker/deploy/script"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deploy is also queued as tsp task.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which server is this being built on?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bare metal - where suites are being run.
I am not doing push to docker hub, just pulling latest changes and rebuilding images.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm better to build this on the web server. The bare metal server might be running benchmarks and building can be CPU intensive affecting the results
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The bare metal server might be running benchmarks and building can be CPU intensive affecting the results
For that reason I enqueue deploy task through tcp
, to ensure no suite is running when deploy is in progress. Have a look at this line we are commenting on ⬆️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better to build this on the web server
I am building images on bare metal server since that's where they are being used. We don't need docker images on web server.
The alternative way would be to build those on Travis and push them to docker hub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea lets build on Travis instead even though it might be slower. We should try and keep the bare-metal free from running any other services except fro benchmarks.
No description provided.