Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sequel scope all with default scope bench #79

Merged
merged 1 commit into from
Jul 26, 2017

Conversation

bmarkons
Copy link
Contributor

Sequel default scope benchmark 馃搱

@noahgibbs
Copy link
Contributor

In general, this looks good. I don't think I see the "admin" boolean field in the schema for the pg and ActiveRecord flavors of this benchmark. Is that intentional?

@bmarkons
Copy link
Contributor Author

Actually admin field exists in schema for ActiveRecord default scope benchmark. Take a look at line #12. As opposed to scope all benchmarks of all flavors where admin field isn't added.

Do you suggest that scope all benchmarks and default scope benchmarks should have same schemas?

@noahgibbs
Copy link
Contributor

Ah, I probably read the wrong file, then. Sorry, if all the scope all benchmarks have the same schema then I was wrong. Carry on :-)

@bmarkons
Copy link
Contributor Author

@bmarkons bmarkons merged commit 2b31a91 into ruby-bench:master Jul 26, 2017
@bmarkons bmarkons deleted the add-sequel-scope-all-bench branch July 26, 2017 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants